• 
      

    Make comment ordering consistent throughout the UI.

    Review Request #9233 — Created Sept. 29, 2017 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    197416e...

    Reviewers

    Inside reviews, comments are ordered with general comments first, then
    screenshot comments (which usually don't exist), then file attachment comments,
    and finally diff comments. Unfortunately, the comments listed in the issue
    summary table and the review dialog didn't follow the same order. This change
    fixes that up, so everything is consistent. As a bonus, when adding new
    general comments within the review dialog, we'll now automatically scroll to
    the newly-created comment editor.

    • Ran unit tests.
    • Ran js-tests.
    • Verified that comments appeared in the correct order for entries, the issue
      summary table, and the review dialog.
    • Verified that adding new general comments in the review dialog had the new
      comments created in the correct spot, and that the dialog scrolled to show
      the new editor.