The description doesn't make it clear what the source of the problem was or how this fixes it. Descriptions should always tell a story of what the reported problem was, why it happened, and how it was fixed. Write it like you're telling someone what you did so they can write a report on it.
As far as I can tell, the event handler really should live on the page's view, not the ReviewRequestEditorView, so I'm not sure why it was moved. What was the source of the problem?

Also the description should always wrap at 70-75 characters. I recommend writing the description in your commit message. Many editors will wrap correctly for Git commits.

"This method displays a popup..."

Ship It!

Ship It!

Only one space between sentences. We're not using typewriters here!

The reviewRequest variable is only used once, so we could remove the variable definition and juts move the model.get call where it's used.

Undo this.

Lets accept e (type Event) as an argument and call e.stopPropagation() and e.preventDefault() instead.

Trailing whitespace

Care to update this to use e.preventDefault() and e.stopPropagation() ? It too can be done at the top of the fn.

No longer true. This function doesn't return anything.

Mind updating this function to use preventDefault and stopPropagation too?

No longer true. This function doesn't return anything.

Mind adding Args to all these functions?

Undo this.

Ship It!

This is on the wrong class. It needs to be on RB.ReviewablePageView. Can you move it, and then we'll need to perform more strict testing.
This particular event handler is from commit 7bfd3ae3, which says:



Fix clicking on actions for review requests.
For mobile usage, the actions now live in a top-level <li> with a

"has-menu" class. This was getting intercepted by an event handler that

was blocking clicks from triggering links. The event selector now points

to menus within that class.

So what you need to do is active the browser's mobile mode. Set it for something like an iPhone 6S size. Reload the page. Then try clicking on actions within the menu. You'll definitely want to try actions a couple levels down, like the Close -> Submitted. Test this both before and after the proper fix.
You should also try using your phone, along with the above test, to make sure it works on mobile devices. You can get the IP of your laptop and try using it instead of localhost in the browser. You might need to configure your firewall appropriately, if it's interfering.

Missing period in the second-to-last paragraph of the description.

For the summary, "in Review Request" is kind of akwardly-worded and not quite correct. I'd suggest the summary be:
Fixed the Update -> Add File review request action not responding to clicks.

This one can do a return false and get rid of e. It's equivalent of these commands. The reason we'd specifically call them is to ensure that they're called before any operations we care about occur, in case ours crash. In this particular case, we don't run any special code, so we can just return false and let jQuery do its thing.

Ship It!