Summary

Unbreak hooks/common.py

Review Request #9198 — Created Sept. 20, 2017 and submitted Nov. 25, 2017, 12:01 p.m.

Information

Owner

consus

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

Both functions call get_api() in a pre-refactoring (see f4a2b05ee3bed7bafa730834c8c792fddcce6119)
fashion that simply does not work anymore. The proper way to fix this would be to support different
styles (password, token, etc) but for now I just want to make git hooks in contrib/ usable again

Testing Done

flake8 passed.

JSHint passed.

Branch:: master

Description:: ~
Both functions call get_api() ina pre-refactoring
~ (see f4a2b05ee3bed7bafa730834c8c792fddcce6119) fashion that simply does
~ not work anymore. The proper way to fix this would be to support different
~
Both functions call get_api() in a pre-refactoring (see f4a2b05ee3bed7bafa730834c8c792fddcce6119)
~ fashion that simply does not work anymore. The proper way to fix this would be to support different
~ styles (password, token, etc) but for now I just want to make git hooks in contrib/ usable again
- styles (password, token, etc) but for now I just want to make git hooks in contrib/
- usable again

Sorry for the delay on this. We're currently prepping for a release, and we just started another term of the student projects course we work with, so it's been pretty busy.

Could you please fill out the "Testing Done" section? Thanks!

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (1b995da)

~		Both functions call get_api() ina pre-refactoring
~		(see f4a2b05ee3bed7bafa730834c8c792fddcce6119) fashion that simply does
~		not work anymore. The proper way to fix this would be to support different
	~	Both functions call get_api() in a pre-refactoring (see f4a2b05ee3bed7bafa730834c8c792fddcce6119)
	~	fashion that simply does not work anymore. The proper way to fix this would be to support different
	~	styles (password, token, etc) but for now I just want to make git hooks in contrib/ usable again
-		styles (password, token, etc) but for now I just want to make git hooks in contrib/
-		usable again