• 
      

    Move entry rendering into dedicated functions.

    Review Request #9174 — Created Sept. 6, 2017 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    de2d58a...

    Reviewers

    This moves the entry rendering from a for loop/include tag in
    review_detail.html to a template tag and accompanying
    BaseReviewRequestPageEntry.render_to_string() method. This is a bit
    more efficient and allows greater control of the context in the
    template.

    Entries can now supply custom context, and the context sets the
    show_entry_statuses_area intelligently based on the entry position,
    ensuring that this state always matches up to the location rendered on
    the page.

    Unit tests were added to ensure that entries are rendered correctly.

    Unit tests pass.

    Tested that all the review request entries were rendering correctly.