Include unverified issues in the review request approval state.

Review Request #9170 - Created Sept. 4, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
1c9e418...
reviewboard

If issues are waiting for verification, don't show the review request as
approved.

Ran unit tests.

  • 0
  • 0
  • 10
  • 0
  • 10
Description From Last Updated
Christian Hammond
  1. 
      
  2. I know we don't have unit tests for this yet. Would you mind writing some, since you're modifying the logic?

    1. What kind of test are you thinking? I don't see any way of testing this method that isn't just "duplicate the logic".

    2. We should have unit tests that test the default approved and unapproved states along with the descriptions, so any future logic changes don't regress, particularly if we ever end up weaving this in deeper with any other services down the road.

  3. 
      
David Trowbridge
Review request changed

Commit:

-228ab6e36a0475cc31e1537e93820e588a628a25
+12e1cedd5155d612fdc84971ae45481672e9a200

Diff:

Revision 2 (+47)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

David Trowbridge
Christian Hammond
  1. 
      
  2. """ on the next line, and no period.

  3. 
      
David Trowbridge
Christian Hammond
  1. Ship It!
  2. 
      
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (4eed931)
Loading...