Fix up special casing for closing review requests.

Review Request #9150 - Created Aug. 25, 2017 and submitted

David Trowbridge
Review Board
release-3.0.x
f68e3d2...
reviewboard

In the case of the close description field, the way that the review request
editor would call reviewRequest.close instead of setting a field on the model
itself was pretty hacky. The implementation of setDraftField would look at
whether it was setting the closeDescription and then special-case its
behavior.

Now that we have JavaScript-side implementations for the built-in fields, we
don't need this anymore. I've moved the special casing into the
CloseDescriptionFieldView.

This refactor will also make things easier down the road for new field types.

  • Tested setting the close description with both regular and Markdown text.
  • Ran js-tests.
  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
David Trowbridge
Christian Hammond
  1. 
      
  2. "javascript" -> "JavaScript" in the description.

  3. Do our unit tests fully cover this change? Is there any way our coverage could be improved based on changes made here?

    1. Yeah, this behavior is covered by tests. I'm not sure there's anything I can do to substantively improve coverage.

    2. Err, scratch that, I can do some test work. Hold tight.

  4. 
      
David Trowbridge
Christian Hammond
David Trowbridge
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (6867d6c)
Loading...