flake8
passed.
JSHint
passed.
Convert ReviewRequestEditorModel to ES6.
Review Request #9147 — Created Aug. 23, 2017 and submitted
Another simple conversion of code that I'm working on.
Ran js-tests.
| Description | From | Last Updated |
|---|---|---|
|
Missing period. |
 brennie
|
|
|
Should we instead be building an array and calling .join('')? Also: ` and "${value}"` |
brennie
|
|
|
`"${value}"` |
brennie
|
|
|
This should probably still pass in the function directly. No sense creating a wrapper function that does nothing but call … |
 chipx86
|
|
|
.bind(this) is implied when using this.listenTo(). |
chipx86
|
|
|
Same here. |
chipx86
|
|
|
Same here. |
chipx86
|
|
|
I liked using options much better, because it allows room for expansion. I'm not sure getDraftField should assume that useExtraData … |
chipx86
|
|
|
Why the direct comparison to true? |
chipx86
|
|
|
This could use template literals to compose the string. |
chipx86
|
|
|
Same here. |
chipx86
|
|
|
Sentence casing. |
chipx86
|
|
|
This could be one line. |
chipx86
|
- Commit:
-
ccd2efc5e7d10135269dfa46f4bd60a9267de3a7b30627c71863026aa0c7496d152fda0ac8a2bc30
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
This should probably still pass in the function directly. No sense creating a wrapper function that does nothing but call the function that
listenTowould call itself. -
-
I liked using
optionsmuch better, because it allows room for expansion. I'm not suregetDraftFieldshould assume thatuseExtraDatais the only field-related option that's going to come up (or that it should be so prominent). Can we go back tooptions? -
-
-
-