Summary

Move text formatting into the TextFieldView.

Review Request #9146 — Created Aug. 23, 2017 and submitted Sept. 26, 2017, 10:18 a.m.

Owner

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

550fecb...

Groups

People

Description

This change moves some code from the ReviewRequestEditorView into the
FieldView subclasses which use it.

Testing Done


Ran js-tests.
Smoke tested fields that required formatting of various sorts.

Issues

Description	From	Last Updated
Do we need to pull this out?	brennie	Aug. 25, 2017, 4:27 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Fix up a place that was using ReviewRequestEditorView.formatText where it ought to have been using RB.formatText.

Commit:

c9376c9920e7989668e15d82e496326567eda407

550fecb4f42d9a0881e2207e8c2c1dd5dd005504

Diff:

Revision 2 (+137 -137)

	reviewboard/static/rb/js/reviewRequestPage/views/changeEntryView.es6.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.es6.js
	reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js

flake8 passed.

JSHint passed.

Ship it!

reviewboard/static/rb/js/views/reviewRequestFieldViews.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Do we need to pull this out?
```

Ship it!