Summary

Refactor the actions system

Review Request #9131 — Created Aug. 11, 2017 and discarded Feb. 28, 2023, 10:30 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is a large patch that refactors the action registry system
implemented by a past student to use a proper registry. Much refactoring
has been done:

Action base classes now live in reviewboard.actions. This package
also includes header dropdown actions.
Review request-specific action classes now live in
reviewboard.reviews.actions.
ALL action hooks support new-style action classes and old-style
dicts. Previously, there was a discrepancy betweeen which hooks
supported which type of action.
ActionHook is now deprecated in favour of ReviewRequestActionHook.
The behaviour was the previously the same, except ActionHook supported
old-style dicts instead of classes. Now that the behaviour of all
hooks has been unified, we no longer need this distinction.
The {% child_actions %} templatetag has been moved from reviewtags
to a new actions template tag library. It now takes the action it
should list the child actions of.
The _DictAction and _DictMenuAction classes have been turned into
the DictActionMixin.
There are now two action registries: one for review request actions
and one for header actions. This allows us to keep them seperate.
We now store instances of dict actions instead of the dicts
themselves. This is because you cannot store a dict in a set (as
it is unhashable) and therefore cannot be put into a Registry.
Generic action templates now live in templates/actions.

Testing Done


Ran unit tests.
Built the docs and looked through them.

Files

Issues

Description	From	Last Updated
W391 blank line at end of file	reviewbot	Aug. 30, 2017, 7:57 p.m.
W391 blank line at end of file	reviewbot	Aug. 30, 2017, 7:57 p.m.
F401 'reviewboard.actions.header.HeaderMenuAction' imported but unused	reviewbot	Aug. 30, 2017, 8:01 p.m.
F401 'reviewboard.actions.header.HeaderAction' imported but unused	reviewbot	Aug. 30, 2017, 8:01 p.m.
F841 local variable 'hook' is assigned to but never used	reviewbot	Aug. 30, 2017, 8:01 p.m.
F821 undefined name 'ReviewRequestAction'	reviewbot	Oct. 20, 2017, 8:58 p.m.
F821 undefined name 'ReviewRequestMenuAction'	reviewbot	Oct. 20, 2017, 8:58 p.m.
Should be changed to 4.0 now.	chipx86	Sept. 4, 2018, 8:27 a.m.
Here, too.	chipx86	Sept. 4, 2018, 8:27 a.m.
And here.	chipx86	Sept. 4, 2018, 8:27 a.m.
= should be removed.	chipx86	Sept. 4, 2018, 8:27 a.m.
Blank line between these.	chipx86	Sept. 4, 2018, 8:27 a.m.
Capitalize the start of "subclasses."	chipx86	Sept. 4, 2018, 8:27 a.m.
Only 1 blank line.	chipx86	Sept. 4, 2018, 8:27 a.m.
Here, too.	chipx86	Sept. 4, 2018, 8:27 a.m.
Here, too.	chipx86	Sept. 4, 2018, 8:27 a.m.
Here, too.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Alphabetical order.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a unicode_literals import.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing the rest of the sentence. Also need one for image_height separately.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing unicode_literals.	chipx86	Sept. 4, 2018, 8:27 a.m.
Incomplete docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing period.	chipx86	Sept. 4, 2018, 8:27 a.m.
Must be the full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Shouldn't use the "If ..." form. Instead, "The parent action is not registered."	chipx86	Sept. 4, 2018, 8:27 a.m.
Same here.	chipx86	Sept. 4, 2018, 8:27 a.m.
No trailing comma on the last parameter to a method.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Leftover debugging.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Must have the full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Just "The item was not foudn in the registry."	chipx86	Sept. 4, 2018, 8:27 a.m.
Full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Alignment issue.	chipx86	Sept. 4, 2018, 8:27 a.m.
Same notes as above with the descriptions.	chipx86	Sept. 4, 2018, 8:27 a.m.
Full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Description on the next line.	chipx86	Sept. 4, 2018, 8:27 a.m.
We should have a module-level logger.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a file docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a unicode_literals import.	chipx86	Sept. 4, 2018, 8:27 a.m.
Needs a full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Description on the next line.	chipx86	Sept. 4, 2018, 8:27 a.m.
Alphabetical order.	chipx86	Sept. 4, 2018, 8:27 a.m.
Should be 4.0 now. And actually, this can now look like: """ ... Deprecated: 3.0: Blah blah """	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Should use str() instead of b'' for future Python compatibility.	chipx86	Sept. 4, 2018, 8:27 a.m.
Needs the full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Same here.	chipx86	Sept. 4, 2018, 8:27 a.m.
And here.	chipx86	Sept. 4, 2018, 8:27 a.m.
And here.	chipx86	Sept. 4, 2018, 8:27 a.m.
Double repr. We don't need the explicit call.	chipx86	Sept. 4, 2018, 8:27 a.m.
No double underscore on the function. That will mangle the name. Needs docs.	chipx86	March 23, 2019, 10:48 p.m.
Needs a full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Should use str() instead of b''.	chipx86	Sept. 4, 2018, 8:27 a.m.
Needs a full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Needs a full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
Needs a full class path.	chipx86	Sept. 4, 2018, 8:27 a.m.
These can be on the same line.	chipx86	Sept. 4, 2018, 8:27 a.m.
No double underscore. Needs docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Leftover debugging.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing a test docstring.	chipx86	Sept. 4, 2018, 8:27 a.m.
Swap these.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
Missing docs.	chipx86	Sept. 4, 2018, 8:27 a.m.
No need for staticfiles or i18n.	chipx86	Sept. 4, 2018, 8:27 a.m.
There should be a book for this.	brennie	March 23, 2019, 10:52 p.m.
E702 multiple statements on one line (semicolon)	reviewbot	Oct. 9, 2018, 7:12 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/actions/header.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
reviewboard/actions/registry.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewboard.actions.header.HeaderMenuAction' imported but unused
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewboard.actions.header.HeaderAction' imported but unused
```
reviewboard/extensions/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'hook' is assigned to but never used
```

Description:

		This is a large patch that refactors the action registry system
		implemented by a past student to use a proper registry. Much refactoring
		has been done:

		Action base classes now live in `reviewboard.actions`. This package also includes header dropdown actions.
		Review request-specific action classes now live in `reviewboard.reviews.actions`.
		ALL action hooks support new-style action classes and old-style dicts. Previously, there was a discrepancy betweeen which hooks supported which type of action.
		`ActionHook` is now deprecated in favour of `ReviewRequestActionHook`. The behaviour was the previously the same, except ActionHook supported old-style dicts instead of classes. Now that the behaviour of all hooks has been unified, we no longer need this distinction.
		The `{% child_actions %}` templatetag has been moved from `reviewtags` to a new `actions` template tag library. It now takes the action it should list the child actions of.
		The `_DictAction` and `_DictMenuAction` classes have been turned into the `DictActionMixin`.
		There are now two action registries: one for review request actions and one for header actions. This allows us to keep them seperate.
		We now store instances of dict actions instead of the dicts themselves. This is because you cannot store a `dict` in a `set` (as it is unhashable) and therefore cannot be put into a `Registry`.
		Generic action templates now live in `templates/actions`.

~		TODO: Docs
	~	TODO: more unit tests.

Testing Done:

~		Ran unit tests.
~		TODO: Smoke testing, more unit tests.
	~	Ran unit tests.
	~	Built the docs and looked through them.

Commit:

add0aa18159f99869655273a52f40cbf98cda8c9

0ccb1bf8908fccba01c1cd83f801be0df14215da

Diff:

Revision 2 (+1256 -1428)

Show changes

	docs/manual/extending/index.rst
	docs/manual/extending/coderef/index.rst
	docs/manual/extending/extensions/hooks/action-hook.rst
	docs/manual/extending/extensions/hooks/index.rst
	docs/manual/webapi/2.0/resources/extension.rst
	docs/manual/webapi/2.0/resources/extension-list.rst
	reviewboard/settings.py
	reviewboard/actions/__init__.py
	20 more

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rebase

Commit:

0ccb1bf8908fccba01c1cd83f801be0df14215da

373472950257d0eee0be15cf79493d74a4137af3

Diff:

Revision 3 (+1247 -1414)

Show changes

	docs/manual/extending/index.rst
	docs/manual/extending/coderef/index.rst
	docs/manual/extending/extensions/hooks/action-hook.rst
	reviewboard/settings.py
	reviewboard/actions/__init__.py
	reviewboard/actions/base.py
	reviewboard/actions/header.py
	reviewboard/actions/registry.py
	16 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/hooks.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F821 undefined name 'ReviewRequestAction'
```
reviewboard/extensions/hooks.py (Diff revision 3)
The issue has been resolved. Show all issues
```
F821 undefined name 'ReviewRequestMenuAction'
```

Change Summary:

Fix typo

Commit:

373472950257d0eee0be15cf79493d74a4137af3

a809dfe28650e474822990ae5adc13a5422f71b0

Diff:

Revision 4 (+1247 -1414)

Show changes

	docs/manual/extending/index.rst
	docs/manual/extending/coderef/index.rst
	docs/manual/extending/extensions/hooks/action-hook.rst
	reviewboard/settings.py
	reviewboard/actions/__init__.py
	reviewboard/actions/base.py
	reviewboard/actions/header.py
	reviewboard/actions/registry.py
	16 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fix templates

Commit:

a809dfe28650e474822990ae5adc13a5422f71b0

a10e69fd25ab2807d1b0b3d8f8e8dc7d151eade7

Diff:

Revision 5 (+1249 -1421)

Show changes

	docs/manual/extending/index.rst
	docs/manual/extending/coderef/index.rst
	docs/manual/extending/extensions/hooks/action-hook.rst
	reviewboard/settings.py
	reviewboard/actions/__init__.py
	reviewboard/actions/base.py
	reviewboard/actions/header.py
	reviewboard/actions/registry.py
	16 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Summary:: WIP: Refactor the actions system
Refactor the actions system
Description:: This is a large patch that refactors the action registry system
implemented by a past student to use a proper registry. Much refactoring
has been done:

Action base classes now live in reviewboard.actions. This package
also includes header dropdown actions.

Review request-specific action classes now live in
reviewboard.reviews.actions.

ALL action hooks support new-style action classes and old-style
dicts. Previously, there was a discrepancy betweeen which hooks
supported which type of action.

ActionHook is now deprecated in favour of ReviewRequestActionHook.
The behaviour was the previously the same, except ActionHook supported
old-style dicts instead of classes. Now that the behaviour of all
hooks has been unified, we no longer need this distinction.

The {% child_actions %} templatetag has been moved from reviewtags
to a new actions template tag library. It now takes the action it
should list the child actions of.

The _DictAction and _DictMenuAction classes have been turned into
the DictActionMixin.

There are now two action registries: one for review request actions
and one for header actions. This allows us to keep them seperate.

We now store instances of dict actions instead of the dicts
themselves. This is because you cannot store a dict in a set (as
it is unhashable) and therefore cannot be put into a Registry.

Generic action templates now live in templates/actions.
-
-
TODO: more unit tests.

Fix it!

This is an old change at this point, and I'm in no way expecting you to finish this work. I just wanted to go through it and make suitable notes on what needs to be done before inclusion, so that we're at a good point to hand it off and continue work.

Of course you're always more than welcome to finish the change, but that's not the priority right now :)

brennie Sept. 4, 2018, 5:37 p.m.

This patch applied cleanly to e794a0945dcc1ed16d5bc2321c5eadc33a1374cc. It does not apply cleanly to 3.0.x

docs/manual/extending/extensions/hooks/action-hook.rst (Diff revision 5)
An issue was opened. Show all issues
```
Should be changed to 4.0 now.
```
docs/manual/extending/extensions/hooks/action-hook.rst (Diff revision 5)
An issue was opened. Show all issues
```
Here, too.
```
docs/manual/extending/extensions/hooks/action-hook.rst (Diff revision 5)
An issue was opened. Show all issues
```
And here.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
= should be removed.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Blank line between these.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Capitalize the start of "subclasses."
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Only 1 blank line.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Here, too.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Here, too.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Here, too.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Alphabetical order.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/base.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/header.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a unicode_literals import.
```
reviewboard/actions/header.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```

reviewboard/actions/header.py (Diff revision 5)

An issue was opened. Show all issues

Missing the rest of the sentence.

Also need one for image_height separately.

reviewboard/actions/header.py (Diff revision 5)

An issue was opened. Show all issues

Missing docs.

reviewboard/actions/header.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing unicode_literals.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Incomplete docstring.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing period.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Must be the full class path.
```

reviewboard/actions/registry.py (Diff revision 5)

An issue was opened. Show all issues

Shouldn't use the "If ..." form. Instead, "The parent action is not registered."

reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Same here.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
No trailing comma on the last parameter to a method.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Leftover debugging.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Must have the full class path.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Just "The item was not foudn in the registry."
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Full class path.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Full class path.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Alignment issue.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Same notes as above with the descriptions.
```
reviewboard/actions/registry.py (Diff revision 5)
An issue was opened. Show all issues
```
Full class path.
```
reviewboard/actions/templatetags/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Description on the next line.
```
reviewboard/actions/templatetags/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
We should have a module-level logger.
```
reviewboard/actions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a file docstring.
```
reviewboard/extensions/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a unicode_literals import.
```
reviewboard/extensions/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs a full class path.
```
reviewboard/extensions/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Description on the next line.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Alphabetical order.
```

reviewboard/extensions/hooks.py (Diff revision 5)

An issue was opened. Show all issues

Should be 4.0 now.

And actually, this can now look like:

"""
...

Deprecated:
    3.0:
    Blah blah
"""

reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Should use str() instead of b'' for future Python compatibility.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs the full class path.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Same here.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
And here.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
And here.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Double repr. We don't need the explicit call.
```

reviewboard/extensions/hooks.py (Diff revision 5)

The issue has been dropped. Show all issues

No double underscore on the function. That will mangle the name.

Needs docs.

brennie March 23, 2019, 10:48 p.m.
```
This was intentional.
```

brennie March 23, 2019, 10:49 p.m.

Or at least it was at some point. I recall there being multiple __from_dict_action methods but :shrug:

reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs a full class path.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Should use str() instead of b''.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs a full class path.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs a full class path.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
Needs a full class path.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
These can be on the same line.
```
reviewboard/extensions/hooks.py (Diff revision 5)
An issue was opened. Show all issues
```
No double underscore.
Needs docs.
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 5)
An issue was opened. Show all issues
```
Leftover debugging.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/extensions/tests.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing a test docstring.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Swap these.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/reviews/actions.py (Diff revision 5)
An issue was opened. Show all issues
```
Missing docs.
```
reviewboard/templates/actions/header_action_dropdown.html (Diff revision 5)
An issue was opened. Show all issues
```
No need for staticfiles or i18n.
```

Change Summary:

This patch can now be applied to release-3.0.x to ease forward porting to 4.0.x.

Commit:

a10e69fd25ab2807d1b0b3d8f8e8dc7d151eade7

cc0e50c126f85f58d819bb5f2a2f144a03b3f749

Diff:

Revision 6 (+1354 -1409)

Show changes

	docs/manual/extending/index.rst
	docs/manual/extending/coderef/index.rst
	docs/manual/extending/extensions/hooks/action-hooks.rst
	reviewboard/settings.py
	reviewboard/actions/__init__.py
	reviewboard/actions/base.py
	reviewboard/actions/header.py
	reviewboard/actions/registry.py
	16 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/actions/base.py (Diff revision 6)
An issue was opened. Show all issues
```
E702 multiple statements on one line (semicolon)
```

Fix it!

docs/manual/extending/extensions/hooks/action-hooks.rst (Diff revision 6)
An issue was opened. Show all issues
```
There should be a book for this.
```
1. brennie March 23, 2019, 10:52 p.m.
  A hook, even.

Status:: Discarded