• 
  
    
 
    
 
    

    



    
    
    
    
     
    






    
 
    


 
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix JavaScript test regressions from recently-merged changes.
    
 
    

    



 
    
 
    

  Review Request #9120
  —
  Created Aug. 4, 2017 and submitted  — Latest diff uploaded 

 
    


    




    




    




 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  Review Board
 
    

    





    
 
 
    
  release-3.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  61421bb...
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewboard
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    Our JavaScript unit tests had a few regressions due to changes made
    
against Review Board 2.0/2.5 that made use of Jasmine functionality and
    
Review Board semantics that were no longer correct on 3.0. There were
    
three breakages:
    

      

    1. 

      RB.DnDUploader on 3.0 no longer allows multiple instances to be
      
   created, and we weren't resetting this.
      

      2. 

    2. 

      Jasmine's andCallFake is now and.callFake.
      

      3. 

    3. 

      The syntax for asynchronous tests in Jasmine changed, breaking the new
      
   XSS tests.
      

      4. 

    

    These issues have all been fixed.
    
 
    

    





  

    
 
 
    
  
    Unit tests pass.