Summary

Fix JavaScript test regressions from recently-merged changes.

Review Request #9120 — Created Aug. 4, 2017 and submitted Aug. 9, 2017, 5:51 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

61421bb...

Reviewers

Groups

reviewboard

People

Description

Our JavaScript unit tests had a few regressions due to changes made
against Review Board 2.0/2.5 that made use of Jasmine functionality and
Review Board semantics that were no longer correct on 3.0. There were
three breakages:

RB.DnDUploader on 3.0 no longer allows multiple instances to be
created, and we weren't resetting this.
Jasmine's andCallFake is now and.callFake.
The syntax for asynchronous tests in Jasmine changed, breaking the new
XSS tests.

These issues have all been fixed.

Testing Done

Unit tests pass.

Issues

Description	From	Last Updated
Typo in summary: changed -> changes	david	Aug. 8, 2017, 2:44 a.m.
Typo in description: asyncronous -> asynchronous	david	Aug. 8, 2017, 2:44 a.m.

JSHint timed out.

The issue has been resolved. Show all issues
```
Typo in summary: changed -> changes
```

The issue has been resolved. Show all issues

Typo in description: asyncronous -> asynchronous

Summary:: Fix JavaScript test regressions from recently-merged changed.
Fix JavaScript test regressions from recently-merged changes.
Description:: Our JavaScript unit tests had a few regressions due to changes made
against Review Board 2.0/2.5 that made use of Jasmine functionality and
Review Board semantics that were no longer correct on 3.0. There were
three breakages:

RB.DnDUploader on 3.0 no longer allows multiple instances to be
created, and we weren't resetting this.

Jasmine's andCallFake is now and.callFake.

~

The syntax for asyncronous tests in Jasmine changed, breaking the new
XSS tests.

~

The syntax for asynchronous tests in Jasmine changed, breaking the new
XSS tests.

These issues have all been fixed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (3761759)

		Our JavaScript unit tests had a few regressions due to changes made
		against Review Board 2.0/2.5 that made use of Jasmine functionality and
		Review Board semantics that were no longer correct on 3.0. There were
		three breakages:

		`RB.DnDUploader` on 3.0 no longer allows multiple instances to be created, and we weren't resetting this.
		Jasmine's `andCallFake` is now `and.callFake`.
~		The syntax for asyncronous tests in Jasmine changed, breaking the new XSS tests.
	~	The syntax for asynchronous tests in Jasmine changed, breaking the new XSS tests.

		These issues have all been fixed.