Move Review Board's search to a SearchForm + generic SearchView
Review Request #9105 — Created July 31, 2017 and submitted — Latest diff uploaded
This patch updates Review Board's
RBSearchView
, which was previously
using Haystack's deprecatedSearchView
with the generic version added
in 2.4 that builds on top of existing Django forms infrastructure. This
means that we now require a minimum version of 2.4.0 for Haystack.The actual search code has been split out into a form that does the
actual searching. This will allow searches to be performed without
setting up a bunch of view rendering infrastructure that we won't need
each time (e.g., from the API).
Ran unit tests.
Diff Revision 1
This is not the most recent revision of the diff. The latest diff is revision 5. See what's changed.
orig
1
2
3
4
5
reviewboard/dependencies.py |
---|
reviewboard/reviews/managers.py |
---|
reviewboard/search/forms.py |
---|
reviewboard/search/tests.py |
---|
reviewboard/search/urls.py |
---|
reviewboard/search/views.py |
---|
reviewboard/search/search_backends/registry.py |
---|
reviewboard/templates/search/results.html |
---|