Summary

Include commit ID in search index.

Review Request #9098 — Created July 24, 2017 and submitted July 26, 2017, 3:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

cbddf83...

Reviewers

Groups

reviewboard

People

Description

This change adds the commit ID to the review request search index. It's also
included in the default document.

Testing Done


Created a search index and searched for commit IDs using both Whoosh and

  Elasticsearch backends.
Ran unit tests.

Issues

Description	From	Last Updated
Can you verify that this was tested with both Whoosh and Elasticsearch?	chipx86	July 26, 2017, 12:23 p.m.

flake8 passed.

JSHint passed.

I'm not sure I'd want to change the text field for current releases. I don't think the *NgramFields are supposed to be that efficient for larger blocks of text. I might be wrong, but I'd need to know more. Maybe evaluate the text field for 3.0?

The issue has been resolved. Show all issues

Can you verify that this was tested with both Whoosh and Elasticsearch?

Description:: This change adds the commit ID to the review request search index. It's also
included in the default document.
-
-
Because of the way that haystack does splitting with CharField, abbreviated
- searches work when specifying commit_id:SHA but won't work for the main
- document. I'm tempted to switch the text field over to be an EdgeNgramField
- but that probably will force everyone to do a full reindex on upgrade.
- Thoughts?
Testing Done:: ~
Created a search index.
~
Searched for commit IDs and saw the correct results.
~
Created a search index and searched for commit IDs using both Whoosh and
Elasticsearch backends.
~
Ran unit tests.
-
Ran unit tests.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (95e6f7b)

		This change adds the commit ID to the review request search index. It's also
		included in the default document.
-
-		Because of the way that haystack does splitting with CharField, abbreviated
-		searches work when specifying `commit_id:SHA` but won't work for the main
-		document. I'm tempted to switch the `text` field over to be an `EdgeNgramField`
-		but that probably will force everyone to do a full reindex on upgrade.
-		Thoughts?

~		Created a search index.
~		Searched for commit IDs and saw the correct results.
	~	Created a search index and searched for commit IDs using both Whoosh and Elasticsearch backends.
	~	Ran unit tests.
-		Ran unit tests.