List OAuth applications under their local sites

Review Request #9094 - Created July 20, 2017 and updated

Barret Rennie
Review Board
release-3.0.x
9096
reviewboard

Previously, all OAuth2 applications were listed in a single list, giving
no distinction to those limited to Local Sites. Now they are grouped
by Local Site so they can be more easily be distinguished.

This change does not add support for creating applications under Local
Sites via the UI.

Testing done:

  • Created and deleted applications on the global site.
  • Deleted applications on a Local Site.
Loading file attachments...

  • 4
  • 13
  • 0
  • 17
Description From Last Updated
"a raw" Christian Hammond Christian Hammond
Blank line between these. Christian Hammond Christian Hammond
Maybe put the [ on the previous line, so these two lines can just be pure list items and on ... Christian Hammond Christian Hammond
We're still doing 2 loops when I'm sure we can do just 1. What's stopping us from using a standard ... Christian Hammond Christian Hammond
Barret Rennie
David Trowbridge
Barret Rennie
David Trowbridge
Barret Rennie
Christian Hammond
Barret Rennie
Review request changed

Checks run (2 succeeded)

JSHint passed.
flake8 passed.
Christian Hammond
  1. 
      
  2. "a raw"

  3. Blank line between these.

  4. Maybe put the [ on the previous line, so these two lines can just be pure list items and on the natural indentation level. That'll also help fix the attributes, which are currently indented 1 space too far.

  5. We're still doing 2 loops when I'm sure we can do just 1. What's stopping us from using a standard dictionary object mapping site names to arrays and doing a standard iteration through it?

  6. 
      
Loading...