• 
      

    Fix a double-confirmation when deleting comments in the Review Dialog.

    Review Request #9089 — Created July 18, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    cd7e569...

    Reviewers

    The Delete Comment icon in the Review Dialog was displaying two
    confirmation prompts when clicked. Either one would trigger the deletion
    of the comment, with the second failing.

    The reason for this is that we had two elements each with the
    delete-comment CSS class, which the event was tied to. Both the
    clickable anchor and the icon itself shared this class.

    This change simply removes the CSS class from the icon. The icon's
    display is not affected, and this removes the double confirmation.

    Tried deleting a comment. Verified that I could click either the cancel
    or confirmation buttons and wouldn't see a second prompt. I was also able
    to successfully cancel or delete the comment.

    Checked to make sure the presentation still seemed correct.

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (f03858b)