• 
      

    Fix 500s from the diff context resource

    Review Request #9065 — Created July 10, 2017 and submitted — Latest diff uploaded

    Information

    Review Board
    release-3.0.x
    ce44bed...

    Reviewers

    The refactoring of views into mixins broke subtly broke the diff context
    resource. It was passing in all arguments positionally and the new
    CheckLocalSiteAccessViewMixin was pulling local_site_name out of both
    kwargs and (mistakenly) from a caller passing *args. We now pass all
    arguments in as keyword arguments to avoid this mess.

    This patch also removes a bunch of dead imports I noticed in
    reviews/views as a result of the aforementioned refactor.

    • Ran unit tests.
    • With this patch applied, there are no more 500s on the diff context
      resource when viewing interdiffs.