This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-3.0.x (b3e28ec)

Summary

Update docs, ES6 for some code related to comments and issues.

Review Request #9049 — Created July 3, 2017 and submitted 7 years, 11 months ago

Information

Owner

david*

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

cc37d9d...

Reviewers

Groups

reviewboard

People

Description*

In preparation for adding issue verification, this change does some simple
cleanup to existing code.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
CommentIssueManager.	brennie	7 years, 11 months ago
Appropriate place for a switch/case?	brennie	7 years, 11 months ago
There are no open issues

flake8 passed.

JSHint passed.

Branch:

master

release-3.0.x

Commit:

c4cb1f1d0ab7e879ed143c00ddb8b515ae387cff

be6d5ad3f18e106b12832c08b7a14703cad35c12

Diff:

Revision 2 (+260 -126)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/static/rb/js/models/commentIssueManagerModel.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
CommentIssueManager.
```
reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js (Diff revision 2)
The issue has been resolved. Show all issues
```
Appropriate place for a switch/case?
```

Commit:

be6d5ad3f18e106b12832c08b7a14703cad35c12

cc37d9dfe98a7ba4a55d542a808deedec1171b79

Diff:

Revision 3 (+270 -126)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/static/rb/js/models/commentIssueManagerModel.js
	reviewboard/static/rb/js/models/commentIssueManagerModel.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Status:: Completed
Change Summary:: Pushed to release-3.0.x (b3e28ec)