3462: Ability to take back a ship-it.
- Fixed
- Review Board
| vlo****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
What version are you running? 2.0.2 What's the URL of the page containing the problem? r/# What steps will reproduce the problem? 1. Make a review & Ship-it 2. Upon further consideration, Ship-it was premature & I want to revoke my ship-it. 3. ??? What is the expected output? What do you see instead? I want to be able to revoke my ship-it so that it doesn't appear in the reviewee's list as shipped. What operating system are you using? What browser? Please provide any additional information below. Unlike issue 489, this is about revoking your own ship-it, not trying to add a third-state where you can request a hold to override someone else's ship-it. However, the proposed tri-state switch in one of the comments might solve this problem to if you could change that switch after a review. Ship-it state is a little too closely tied to a particular perons's review of a review request instead of being a state on the review request.
-
+ Confirmed -
- Type-Defect + Type-Enhancement + Component-Reviews
I'm curious if this is fixed by the new ship-it column in 2.0.x. If you add a new review that has issues, the ship-it won't be shown, and instead the issue count will be.
Not really. A review may have larger issues (e.g. architectural) that are not issues related to any specific line.
Also, someone may mark all the single line issues as fixed/dropped without addressing larger issues that may be raised that invalidate the ship-it.
Bump? I know a number of people that would love to have this feature. It would really help out with our horizontal focus on code quality.
Feature up for review for Review Board 3.0. https://reviews.reviewboard.org/r/8995/
-
- Confirmed + PendingReview -
+ Release-3.0 -
+ chipx86