Summary

Add a backport of Django 1.8's URLValidator.

Review Request #8978 — Created May 30, 2017 and submitted June 8, 2017, 4 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

50ef07d...

Reviewers

Groups

djblets

People

Description

The URLValidator that ships with Django 1.6 is pretty basic, and doesn't
understand URLs that include credentials. This change adds a backport of the
Django 1.8 version, which does that plus more.

Testing Done

Used this in conjunction with a change in Review Board.

Issues

Description	From	Last Updated
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E501 line too long (87 > 79 characters)	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E501 line too long (87 > 79 characters)	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E101 indentation contains mixed spaces and tabs	reviewbot	May 30, 2017, 2 p.m.
W191 indentation contains tabs	reviewbot	May 30, 2017, 2 p.m.
E501 line too long (80 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (94 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (94 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (82 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (84 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (90 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
F821 undefined name 'validate_ipv6_address'	reviewbot	May 30, 2017, 2:05 p.m.
E501 line too long (83 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (82 > 79 characters)	reviewbot	May 30, 2017, 2:03 p.m.
E501 line too long (83 > 79 characters)	reviewbot	May 30, 2017, 2:05 p.m.
E501 line too long (80 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (94 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (94 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (82 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (84 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (90 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (83 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (82 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.
E501 line too long (83 > 79 characters)	reviewbot	May 30, 2017, 2:25 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 109 failures.
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (87 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (87 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E101 indentation contains mixed spaces and tabs
```
djblets/util/compat/django/core/validators.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W191 indentation contains tabs
```

Commit:

f2980e84a3c410cd2a0934e4215f2b7ae37c557a

e2ef834a1b4788021950bdf1597388a148abe614

Diff:

Revision 2 (+126)

Show changes

djblets/util/compat/django/core/validators.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (94 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (94 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (84 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F821 undefined name 'validate_ipv6_address'
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```

Commit:

e2ef834a1b4788021950bdf1597388a148abe614

50ef07dfa97a36c438d7ee1620b9659476eac2b3

Diff:

Revision 3 (+127)

Show changes

djblets/util/compat/django/core/validators.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (94 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (94 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (84 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (90 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (82 > 79 characters)
```
djblets/util/compat/django/core/validators.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-0.9.x (a45860e)