Fix mangling of SVN diffs that contain lines that look like headers.
Review Request #8934 — Created May 9, 2017 and submitted
If a file has a removed line that looks vaguely like a file header (i.e. the
line is "-- XX (Y)"), the entry for the removed line in the diff would get
filtered out by our code that tries to mangle the diffs to make renames and
copies work properly.This change makes the code that detects and mangles file headers much more
specific, looking at each chunk of 5 lines instead of lines one by one.
- Created a reproduction case and verified that
rbt diffandsvn diff
produced the same output. - Wrote a unit test and checked that the test failed before the change and
succeeded afterward. - Ran entire test suite.
| Description | From | Last Updated |
|---|---|---|
|
W503 line break before binary operator |
 reviewbot
|
|
|
I'd kinda rather keep the and at the end of the line, so we don't deal with errors every time … |
 chipx86
|
|
|
W503 line break before binary operator |
reviewbot
|
|
|
W503 line break before binary operator |
reviewbot
|
|
|
W503 line break before binary operator |
reviewbot
|
