Summary

Update the touch event proxying code to better represent mouse events.

Review Request #8932 — Created May 8, 2017 and submitted May 12, 2017, 4:33 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-0.9.x

Bugs

Depends On

Commit

308deb8...

Reviewers

Groups

djblets

People

Description

$.fn.proxyTouchEvents() now simulates mouseover/mouseout events, better
helping to make touch events compatible with more pieces of UI (in
particular, for the purposes of this change, jQuery-UI's resizable
widget). It now keeps track of what elements the user has moved their
finger over in the calculation of the events.

Touch events are only proxied if using one finger. Gestures are left
alone so that the page or browser can handle them.

This does not yet implement the mouseenter/mouseleave events, though,
which are a bit more complicated to get right.

Testing Done

Tested with Review Board's comment dialog, which utilizes the resizable
widget. Saw that I was able to drag the handle around, verifying that the
mouseover/mouseout events were working.

Issues

Description	From	Last Updated
This variable is never defined.	david	May 9, 2017, 1:43 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Updated to ignore multi-finger events.

Description:

		`$.fn.proxyTouchEvents()` now simulates mouseover/mouseout events, better
		helping to make touch events compatible with more pieces of UI (in
		particular, for the purposes of this change, jQuery-UI's `resizable`
		widget). It now keeps track of what elements the user has moved their
		finger over in the calculation of the events.

	+	Touch events are only proxied if using one finger. Gestures are left
	+	alone so that the page or browser can handle them.
	+
		This does not yet implement the mouseenter/mouseleave events, though,
		which are a bit more complicated to get right.

Commit:

844c2a2f4c1485045882b19342e04e1cdf934389

2f37c7815232b270f4985686a710295c6e853032

Diff:

Revision 2 (+53 -21)

Show changes

djblets/static/djblets/js/jquery.gravy.util.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/static/djblets/js/jquery.gravy.util.js (Diff revision 2)
The issue has been resolved. Show all issues
```
This variable is never defined.
```
1. chipx86 May 9, 2017, 1:43 p.m.
  Huh, thought JSHint would have caught that.
2. david May 9, 2017, 1:45 p.m.
  It has a hard time knowing what's defined in the closure or globally...