• 
      

    Avoid raising TypeError for missing *_last_id value in condition fields.

    Review Request #8917 — Created April 27, 2017 and submitted

    Information

    Djblets
    master
    7f85cce...

    Reviewers

    The value_from_datadict() method would raise a TypeError if the *_last_id
    value was missing from data. The code was expecting to catch KeyError,
    but was using data.get() instead of data[] and passing None to int().
    Added test cases for empty data dictionary and missing *_last_id value.
    The new test cases fail before the change and all tests succeed after.
    brennie
    1. Ship It!
    2. 
        
    MU
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.10.x (e606887)