Summary

Ensure that oauth2_provider.admin is registered before ours

Review Request #8884 — Created April 6, 2017 and submitted April 18, 2017, 9:29 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

During unit tests, it is possible that the oauth2_provider module's

admin registrations won't happen before we go to remove their

registration for the Application model to replace it with our own. We

now import the module (purely for side effects) in our oauth.admin

module to ensure that happens.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
'oauth2_provider.admin' imported but unused	reviewbot	April 6, 2017, 3:52 p.m.
You can instead do: import importlib ... importlib.import_module('oauth2_provider.admin')	chipx86	April 12, 2017, 12:43 p.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes failed.

Pyflakes

reviewboard/oauth/admin.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'oauth2_provider.admin' imported but unused
```

reviewboard/oauth/admin.py (Diff revision 1)

The issue has been resolved. Show all issues

You can instead do:

import importlib

...

importlib.import_module('oauth2_provider.admin')

Change Summary:

Replace import # NOQA with importlib.import_module

Diff:

Revision 2 (+7 -1)

Show changes

reviewboard/oauth/admin.py

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (da2af15)