JSHint
passed.
PEP8 Style Checker
internal error.
Pyflakes
passed.
Review Request #8879 — Created April 6, 2017 and submitted
The Diff Size column was doing a query on the DiffSetHistory, latest DiffSet, and all FileDiffs for each and every review request. This wasn't great for performance. This change adds prefetching for the diffsets and filediffs, reducing the queries substantially. We still do need the filediffs, since total line counts aren't cached on the diffset (and even if they were, we'd still need to make the filediffs query for those not cached). It's still one of the more expensive columns, but far less than it used to be.
Unit tests pass.
Inspected the SQL statements for the datagrid. Saw that there were no
longer large numbers of queries.