Summary

Handle a missing "cvs" binary better.

Review Request #886 — Created June 7, 2009 and submitted

Information

Owner

david

Repository

Review Board SVN (deprecated)

Branch

trunk

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Handle a missing "cvs" binary better.

In our dependency checks, SCMTool and unit tests, we didn't handle a missing
"cvs" binary in the same way we do for many of our other dependencies. I noticed
this because Ubuntu doesn't install CVS by default anymore (hooray!). This
change fixes up all the places so that we don't throw errors.

Testing Done

Making the following changes and shipping it for RC3, as requested.

/trunk/reviewboard/manage.py (Diff revision 1)
```
Blank line here.
```

/trunk/reviewboard/manage.py (Diff revision 1)

Needs to check for binaryname and binaryname.exe, since it won't work on Windows otherwise.

Should also space these out more.

/trunk/reviewboard/manage.py (Diff revision 1)

Blank line between each of these.

/trunk/reviewboard/scmtools/cvs.py (Diff revision 1)
```
Blank line here.
```
/trunk/reviewboard/scmtools/cvs.py (Diff revision 1)
```
Should check for cvs and cvs.exe.
```
/trunk/reviewboard/scmtools/cvs.py (Diff revision 1)
```
Blank line here.
```