• 
      

    [WIP] Replace old selectors with smarter objects selector widget in the administration UI

    Review Request #8846 — Created March 26, 2017 and discarded

    Information

    Review Board
    master

    Reviewers

    TODO
    The administration UI currently uses Django's default multi-object field selector widget for choosing groups and repositories. This implementation loads all objects at once on load and does not scale well on large implementations.

    These changes replace the old selectors with a new, smarter objects selector widget. This widget has already been implemented in Review Board 2.5.7+ for selecting users. So, these changes involve removing the widget class from Review Board (and added to Djblets with Review Request 8845), adjusting the existing user selectors to use the moved class, and replacing old selectors to use the new selector. This includes groups and repository selectors in the administration UI.

    
     
    Description From Last Updated

    'djblets.forms.RelatedObjectWidget' imported but unused

    reviewbotreviewbot

    undefined name 'none'

    reviewbotreviewbot

    undefined name 'none'

    reviewbotreviewbot
    Checks run (1 failed, 2 succeeded)
    JSHint passed.
    PEP8 Style Checker passed.
    Pyflakes failed.

    Pyflakes

    szhang
    szhang
    Review request changed
    Commit:
    d7e9c301081755b5b30f864f2e693293f9cce064
    bd5cefb400051061e8a9fb91573a465bca23894d

    Checks run (1 failed, 1 succeeded, 1 failed with error)

    JSHint passed.
    PEP8 Style Checker internal error.
    Pyflakes failed.

    Pyflakes

    david
    Review request changed
    Status:
    Discarded