Summary

Send an e-mail when a user's password has changed

Review Request #8815 — Created March 14, 2017 and submitted March 20, 2017, 5:26 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We now can optionally send an e-mail notification when a user's password
changes. Whether or not this is enabled is via a SiteConfiguration
settings (defaulting to disbaled), which has been added to the e-mail
settings form im the administration panel.

Testing Done


Previewed the e-mails.
Changed my password and saw the e-mail go out in the console.

Files

Issues

Description	From	Last Updated
No docstring?	szhang	March 23, 2017, 10:39 a.m.
Typo: dokens -> tokens	szhang	March 23, 2017, 10:39 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/forms/pages.py
    reviewboard/notifications/email.py

Ignored Files:
    reviewboard/templates/notifications/password_changed.html
    reviewboard/templates/notifications/password_changed.txt



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/siteconfig.py
    reviewboard/admin/forms.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/forms/pages.py
    reviewboard/notifications/email.py

Ignored Files:
    reviewboard/templates/notifications/password_changed.html
    reviewboard/templates/notifications/password_changed.txt

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (cbf1bf7)

Ship it! Fix it!

Hey, I'm not sure how this would work since the changes were shipped. I actually had a pending review about some small issues that I should have posted:

reviewboard/accounts/views.py (Diff revision 1)

An issue was opened. Show all issues

No docstring?

reviewboard/templates/notifications/password_changed.html (Diff revision 1)
An issue was opened. Show all issues
```
Typo: dokens -> tokens
```