Send an e-mail when a user's password has changed

Review Request #8815 — Created March 14, 2017 and submitted

Information

Review Board
release-3.0.x

Reviewers

We now can optionally send an e-mail notification when a user's password
changes. Whether or not this is enabled is via a SiteConfiguration
settings (defaulting to disbaled), which has been added to the e-mail
settings form im the administration panel.

  • Previewed the e-mails.
  • Changed my password and saw the e-mail go out in the console.
------------------------------------------
This is an automatically generated e-mail.
------------------------------------------
Hi barret,
Your password has been successfully changed on <http://example.com/>.
If you did not change your password, please contact a server administrator
immediately.
You currently have API tokens. Changing your password does not reset them. If
you wish to invalidate your API tokens, you must do that manually at
<http://example.com/account/preferences/#api-tokens>.

Description From Last Updated

No docstring?

szhangszhang

Typo: dokens -> tokens

szhangszhang
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/accounts/views.py
        reviewboard/accounts/urls.py
        reviewboard/accounts/forms/pages.py
        reviewboard/notifications/email.py
    
    Ignored Files:
        reviewboard/templates/notifications/password_changed.html
        reviewboard/templates/notifications/password_changed.txt
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/admin/siteconfig.py
        reviewboard/admin/forms.py
        reviewboard/accounts/views.py
        reviewboard/accounts/urls.py
        reviewboard/accounts/forms/pages.py
        reviewboard/notifications/email.py
    
    Ignored Files:
        reviewboard/templates/notifications/password_changed.html
        reviewboard/templates/notifications/password_changed.txt
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (cbf1bf7)
szhang
  1. Hey, I'm not sure how this would work since the changes were shipped. I actually had a pending review about some small issues that I should have posted:

  2. reviewboard/accounts/views.py (Diff revision 1)
     
     
     
     
     
     
     
     
    Show all issues

    No docstring?

  3. Show all issues

    Typo: dokens -> tokens

  4. 
      
Loading...