Summary

Notify a slack channel as well as each user for all review hooks in rbslack

Review Request #8777 — Created Feb. 23, 2017 and discarded Nov. 17, 2017, 11:27 a.m.

Information

Owner

sideshowdave7

Repository

rb-extension-pack

Branch

master

Bugs

Depends On

Reviewers

Groups

rb-extension-pack

People

Description

This change changes the behaviour of notification to also send messages directly to users. This requires users in Slack and ReviewBoard to match (documentation added). This provides a nice feed for each user to get updates on only the reviews they care about. The users it notifies are the submitter, any people/group members assigned the to review and any commenters.

Also this adds a header on the payload sent, Content-type: application/json to support the Slack open-source alternative MatterMost. (This follows the slack documentation's request to have this header present)

Testing Done

Tested with MatterMost, which claims 100% api compatibility with Slack.

Issues

Description	From	Last Updated
undefined name 'self'	reviewbot	Feb. 23, 2017, 2:37 p.m.

Tool: PEP8 Style Checker
Processed Files:
    rbslack/rbslack/extension.py

Ignored Files:
    rbslack/README.md



Tool: Pyflakes
Processed Files:
    rbslack/rbslack/extension.py

Ignored Files:
    rbslack/README.md

rbslack/rbslack/extension.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 undefined name 'self'
```

Change Summary:

PEP8 style checker fix

Commit:

67f6a449b32104364f4f44ccf411a87653eef42c

8da126c1fa43ec27e9cc0b877b75e4901422c9d9

Diff:

Revision 2 (+36 -11)

Show changes

	rbslack/README.md
	rbslack/rbslack/extension.py

Tool: Pyflakes
Processed Files:
    rbslack/rbslack/extension.py

Ignored Files:
    rbslack/README.md



Tool: PEP8 Style Checker
Processed Files:
    rbslack/rbslack/extension.py

Ignored Files:
    rbslack/README.md

Status:: Discarded