Add an optional config file for the Review Bot worker.
Review Request #8773 — Created Feb. 21, 2017 and submitted
The worker currently runs without configuration, but some of the new features
we're looking at will require it. In particular, the immediate need is that
PMD, a tool which we'll be adding, does not have a standard installation
mechanism, and often is run via a script from the download directory. The path
to this script has to be configured for the tool to work.While I was in here, I fixed up the task serialization/accept config to get rid
of a big warning about accepting pickle content (which is insecure and going
away in future versions), and corrected the method of setting the broker URL,
which I hadn't noticed was incorrect because it defaults to localhost.
Ran the worker with and without a config file in place. Saw the expected
output, and that the (future) PMD tool loaded correctly.
| Description | From | Last Updated |
|---|---|---|
|
One line? |
 brennie
|
- Description:
-
The worker currently runs without configuration, but some of the new features
we're looking at will require it. In particular, the immediate need is that PMD, a tool which we'll be adding, does not have a standard installation mechanism, and often is run via a script from the download directory. The path to this script has to be configured for the tool to work. While I was in here, I fixed up the task serialization/accept config to get rid
of a big warning about accepting pickle content (which is insecure and going away in future versions). - - Testing done:
- Ran the worker with and without a config file in place. Saw the expected - output, and that the (future) PMD tool loaded correctly. - Commit:
-
e257e40a68a2cdedbe8f764e103930e89c3f2266977c9201e579b48456fdd345b0d11e267cffba68
-
Tool: PEP8 Style Checker Processed Files: bot/setup.py bot/reviewbot/celery.py extension/reviewbotext/extension.py bot/reviewbot/config.py Tool: Pyflakes Processed Files: bot/setup.py bot/reviewbot/celery.py extension/reviewbotext/extension.py bot/reviewbot/config.py
- Description:
-
The worker currently runs without configuration, but some of the new features
we're looking at will require it. In particular, the immediate need is that PMD, a tool which we'll be adding, does not have a standard installation mechanism, and often is run via a script from the download directory. The path to this script has to be configured for the tool to work. While I was in here, I fixed up the task serialization/accept config to get rid
of a big warning about accepting pickle content (which is insecure and going ~ away in future versions). ~ away in future versions), and corrected the method of setting the broker URL, + which I hadn't noticed was incorrect because it defaults to localhost. - Commit:
-
977c9201e579b48456fdd345b0d11e267cffba686e61175cdd30bd8d2246a21051bb3b18e11c885b
Tool: PEP8 Style Checker Processed Files: bot/reviewbot/celery.py extension/reviewbotext/extension.py bot/reviewbot/config.py Tool: Pyflakes Processed Files: bot/reviewbot/celery.py extension/reviewbotext/extension.py bot/reviewbot/config.py