Summary

Simplify tool execution and improve code documentation.

Review Request #8766 — Created Feb. 19, 2017 and discarded Feb. 21, 2017, 11:12 a.m.

Information

Owner

david

Repository

ReviewBot

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

Because we now use status updates for reporting Review Bot tool results, we
don't need to keep track of which files were processed or ignored. This change
simplifies that, and updates all the tools to include docstrings where
appropriate.

Testing Done

Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/__init__.py
    bot/reviewbot/tools/pyflakes.py
    bot/reviewbot/tools/pmd.py
    bot/reviewbot/tools/cppcheck.py
    bot/reviewbot/tools/cpplint.py
    bot/reviewbot/tools/buildbot.py
    bot/reviewbot/tools/pep8.py
    bot/reviewbot/tools/jshint.py

Change Summary:

Syntax

Commit:

ca610e23a3c1170a8bd22eb17102ebfac783b84b

403c8c70a6ff8756a239fbdf4ac8ba136ad435f6

Diff:

Revision 2 (+153 -46)

Show changes

	bot/reviewbot/tools/__init__.py
	bot/reviewbot/tools/buildbot.py
	bot/reviewbot/tools/cppcheck.py
	bot/reviewbot/tools/cpplint.py
	bot/reviewbot/tools/jshint.py
	bot/reviewbot/tools/pep8.py
	bot/reviewbot/tools/pmd.py
	bot/reviewbot/tools/pyflakes.py

Tool: Pyflakes
Processed Files:
    bot/reviewbot/tools/__init__.py
    bot/reviewbot/tools/pyflakes.py
    bot/reviewbot/tools/pmd.py
    bot/reviewbot/tools/cppcheck.py
    bot/reviewbot/tools/cpplint.py
    bot/reviewbot/tools/buildbot.py
    bot/reviewbot/tools/pep8.py
    bot/reviewbot/tools/jshint.py



Tool: PEP8 Style Checker
Processed Files:
    bot/reviewbot/tools/__init__.py
    bot/reviewbot/tools/pyflakes.py
    bot/reviewbot/tools/pmd.py
    bot/reviewbot/tools/cppcheck.py
    bot/reviewbot/tools/cpplint.py
    bot/reviewbot/tools/buildbot.py
    bot/reviewbot/tools/pep8.py
    bot/reviewbot/tools/jshint.py

Status:: Discarded