Summary

Update management commands to work on newer versions of Django.

Review Request #8742 — Created Feb. 13, 2017 and submitted March 9, 2017, 2:41 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

master

Bugs

Depends On

Commit

b2396f0...

Reviewers

Groups

django-evolution

People

Description

Modern versions of Django require some changes for management commands.
For instance, ArgumentParser is used instead of OptionParser, and
options can't be defined directly on the class.

Django Evolution needs to support versions of Django prior to these
changes. In order to do that, we now have a new base class for
management commands that allows subclasses to adhere to the new
requirements while also providing backwards-compatibility for older
versions of Django. All common types of options are supported.

This brings us a step closer to supporting Django 1.10.

Testing Done

Unit tests pass.

Tested the management commands on Django 1.6 through 1.10.

Tested Djblets against these changes on Django 1.6 through 1.10.

Issues

Description	From	Last Updated
I don't see where this method is used	david	March 6, 2017, 2:54 p.m.
Docstring?	david	March 6, 2017, 2:57 p.m.
Docstring?	david	March 6, 2017, 2:57 p.m.
'make_option' imported but unused	reviewbot	March 6, 2017, 2:58 p.m.
It might be nice to extract everything within this block into its own method--things are getting pretty deeply nested.	david	March 6, 2017, 2:52 p.m.
The cursor needs to be closed.	david	March 9, 2017, 12:55 p.m.

Tool: PEP8 Style Checker
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py



Tool: Pyflakes
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py

django_evolution/management/commands/evolve.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'make_option' imported but unused
```

django_evolution/compat/commands.py (Diff revision 1)
The issue has been dropped. Show all issues
```
I don't see where this method is used
```
1. chipx86 March 6, 2017, 2:58 p.m.
  This is used internally by Django. I'll add docs.
django_evolution/compat/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```
django_evolution/compat/commands.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Docstring?
```

django_evolution/management/commands/evolve.py (Diff revision 1)

The issue has been dropped. Show all issues

It might be nice to extract everything within this block into its own method--things are getting pretty deeply nested.

chipx86 March 6, 2017, 2:58 p.m.

I don't want to do any surgery for this command in this change.

django_evolution/management/commands/evolve.py (Diff revision 1)

The issue has been resolved. Show all issues

The cursor needs to be closed.

chipx86 March 6, 2017, 2:58 p.m.

Not making any changes beyond porting for this change. There's larger work I'd like to do anyway to gut most of this command.

david March 6, 2017, 3:56 p.m.
```
At least add a FIXME or TODO comment?
```

Change Summary:


Added docstrings.
Removed an unused import.

Commit:

45d89420ad94a9c8ac60b4e1c38aab46ba0b83ec

cdfb0bf4202e25973924c31f9dad4af12ab58a5e

Diff:

Revision 2 (+272 -96)

Show changes

	django_evolution/compat/commands.py
	django_evolution/management/commands/evolve.py
	django_evolution/management/commands/list-evolutions.py
	django_evolution/management/commands/wipe-evolution.py

Tool: Pyflakes
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py

Change Summary:

Added a TODO comment about closing the cursor.

Commit:

cdfb0bf4202e25973924c31f9dad4af12ab58a5e

b2396f0c06f6a043f00ba86ba3ea0737bfd26842

Diff:

Revision 3 (+273 -96)

Show changes

	django_evolution/compat/commands.py
	django_evolution/management/commands/evolve.py
	django_evolution/management/commands/list-evolutions.py
	django_evolution/management/commands/wipe-evolution.py

Tool: Pyflakes
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py



Tool: PEP8 Style Checker
Processed Files:
    django_evolution/management/commands/wipe-evolution.py
    django_evolution/management/commands/evolve.py
    django_evolution/management/commands/list-evolutions.py
    django_evolution/compat/commands.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (597cbeb)