Fix up a few bugs in the js code.

Review Request #8737 — Created Feb. 10, 2017 and submitted — Latest diff uploaded

Information

Review Board
release-3.0.x
0c47a94...

Reviewers

This change fixes a few issues that SonarQube surfaced:

  • In a couple places, we were iterating over object fields without testing
    hasOwnProperty.
  • The calls to testCloseDescription were passing too many arguments.
  • We were testing whether indexOf returned a value greater than zero, but
    zero is a valid return value.

Ran js-tests.