Summary

Clean up use of deprecated HTML tags.

Review Request #8736 — Created Feb. 10, 2017 and submitted April 12, 2017, 5:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

894fb6e...

Reviewers

Groups

reviewboard

People

Description

The <b>, <i>, and <tt> tags have all been deprecated for a while. This

change cleans things up to use their modern equivalents. There's still some use

of <font> in e-mail templates, but apparently we have to keep that around for

compatibility with terrible e-mail clients.

Testing Done

Issues

Description	From	Last Updated
This should probably be done as : {% blocktrans with query=query %} No review requests matching your query: {{query}} {% …	brennie	Feb. 15, 2017, 12:02 p.m.
The usage of <font size="2"> was to ensure compatibility on some e-mail clients that ignored the font-size CSS rule. HTML …	chipx86	Feb. 15, 2017, 4:12 p.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html

reviewboard/templates/search/results.html (Diff revision 1)

The issue has been resolved. Show all issues

This should probably be done as :

{% blocktrans with query=query %}
No review requests matching your query: {{query}}
{% endblocktrans %}


because we are including the query in the sentence and other languages may handle this differently. (Or you can ignore this if its too overly safe.)

Commit:

c9ca5980a7cec742fac29d9393a92ce0056132d0

27b5e5e12db1150fe32c0e3002e7a0cc2ff70ca3

Diff:

Revision 2 (+68 -62)

Show changes

	reviewboard/templates/404.html
	reviewboard/templates/admin/cache_stats.html
	reviewboard/templates/admin/ssh_settings.html
	reviewboard/templates/admin/manual-updates/data-dir.html
	reviewboard/templates/admin/manual-updates/ext-dir.html
	reviewboard/templates/admin/manual-updates/install-patch.html
	reviewboard/templates/admin/manual-updates/media-upload-dir.html
	reviewboard/templates/admin/manual-updates/server-static-config.html
	15 more

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html



Tool: Pyflakes
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html

Let me just take a moment to grumble in the general direction of the W3C that <code> being a replacement for <tt> is downright silly, <tt> is far more correct than <code> for a whole lot of things, and is likely to never lose browser support...

reviewboard/templates/notifications/email_diff_comment_fragment.html (Diff revision 2)

The issue has been resolved. Show all issues

The usage of <font size="2"> was to ensure compatibility on some e-mail clients that ignored the font-size CSS rule. HTML in e-mail doesn't follow the same Best Practices or deprecations rules of standard HTML. I'm tempted to say let's keep this as it is unless you can afford the time to do some very thorough testing across a range of e-mail clients. (10pt might also not be a safe bet for all e-mail clients anyway -- percentages would be safer.)

Description:

~		The `<b>`, `<i>`, `<font>`, and `<tt>` tags have all been deprecated for a
~		while. This change cleans things up to use their modern equivalents.
	~	The `<b>`, `<i>`, and `<tt>` tags have all been deprecated for a while. This
	~	change cleans things up to use their modern equivalents. There's still some use
	+	of `<font>` in e-mail templates, but apparently we have to keep that around for
	+	compatibility with terrible e-mail clients.

Commit:

27b5e5e12db1150fe32c0e3002e7a0cc2ff70ca3

894fb6e180986ac2a89e941480629d42c88c1b28

Diff:

Revision 3 (+69 -63)

Show changes

	reviewboard/templates/404.html
	reviewboard/templates/admin/cache_stats.html
	reviewboard/templates/admin/ssh_settings.html
	reviewboard/templates/admin/manual-updates/data-dir.html
	reviewboard/templates/admin/manual-updates/ext-dir.html
	reviewboard/templates/admin/manual-updates/install-patch.html
	reviewboard/templates/admin/manual-updates/media-upload-dir.html
	reviewboard/templates/admin/manual-updates/server-static-config.html
	15 more

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html



Tool: Pyflakes
Ignored Files:
    reviewboard/templates/hostingsvcs/bitbucket/repo_hook_instructions.html
    reviewboard/templates/admin/cache_stats.html
    reviewboard/templates/admin/ssh_settings.html
    reviewboard/templates/notifications/review_request_email.html
    reviewboard/templates/admin/manual-updates/data-dir.html
    reviewboard/templates/admin/manual-updates/install-patch.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/templates/search/results.html
    reviewboard/templates/reviews/boxes/change.html
    reviewboard/templates/admin/manual-updates/version-mismatch.html
    reviewboard/templates/admin/manual-updates/ext-dir.html
    reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
    reviewboard/templates/404.html
    reviewboard/templates/hostingsvcs/github/repo_hook_instructions.html
    reviewboard/templates/notifications/email_diff_comment_fragment.html
    reviewboard/templates/notifications/reply_email.html
    reviewboard/templates/notifications/api_token_updated.html
    reviewboard/templates/notifications/api_token_created.html
    reviewboard/templates/admin/manual-updates/server-static-config.html
    reviewboard/templates/hostingsvcs/googlecode/repo_hook_instructions.html
    reviewboard/templates/admin/scmtools/repository/change_form.html
    reviewboard/templates/admin/manual-updates/media-upload-dir.html
    reviewboard/templates/notifications/api_token_deleted.html

Ship it!

```
Ship It!
```

Ship it!

Can this be backported to 2.5.x? Would help with future merges.

Status:: Completed
Change Summary:: Pushed to release-2.5.x (c9fef4e)