• 
      

    Fix some problems with undefined variables in js code.

    Review Request #8733 — Created Feb. 10, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    2a4294b...

    Reviewers

    There were a few places in our JS where we were making use of things which were
    guaranteed to be undefined. These were mostly typos and think-os.

    Ran js-tests.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
          reviewboard/static/rb/js/ui/views/notificationManager.es6.js
          reviewboard/static/rb/js/views/textCommentRowSelector.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/diffviewer/views/tests/diffReviewableViewTests.js
          reviewboard/static/rb/js/ui/views/notificationManager.es6.js
          reviewboard/static/rb/js/views/textCommentRowSelector.js
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (c94eccd)