Fix TestCase.create_webhook to set events as a list.

Review Request #8712 — Created Feb. 3, 2017 and submitted

Information

Review Board
release-3.0.x
41caa5a...

Reviewers

django-multiselectfield will do some comma-splitting when it loads a value from
the db, but if you set the value in the field to a string and immediately read
it back without committing to the db, it will return a string rather than a
list. In this case, webhooks that were created by a testcase running under
Django 1.8 (which dumps each test case into an atomic block) were failing
because the value read back was '*' instead of ['*'].

Ran unit tests on Django 1.6 and 1.8.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/testing/testcase.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/testing/testcase.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (08d67a7)
Loading...