Summary

Call django.setup() as part of reviewboard.initialize()

Review Request #8711 — Created Feb. 3, 2017 and submitted Feb. 7, 2017, 10:08 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

dc7e57e...

Reviewers

Groups

reviewboard

People

Description

In Django 1.7+, there's a new setup() function which initializes logging and

apps. Attempting to do too much before this is called will fail with errors.

This change adds a call to that during our initialize() method.

Testing Done


Ran unit tests on Django 1.6 and 1.8.
Ran the devserver on 1.8.

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	Feb. 3, 2017, 3:28 p.m.
To match the other version-dependent sections like this, can you add a # Django >= 1.7 before the import?	chipx86	Feb. 3, 2017, 10:26 p.m.
'reviewboard' imported but unused	reviewbot	Feb. 3, 2017, 10:27 p.m.
'reviewboard' imported but unused	reviewbot	Feb. 6, 2017, 4:32 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/__init__.py

reviewboard/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```

Ship it!

```
Ship It!
```

reviewboard/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

To match the other version-dependent sections like this, can you add a # Django >= 1.7 before the import?

Commit:

8c3cb9fb139118d5cef6ab1c7f4d0bf4953aea8a

77d4a42ffdec03333f36170ad65a03f65a2ae3d2

Diff:

Revision 2 (+8)

Show changes

reviewboard/__init__.py

Tool: Pyflakes
Processed Files:
    reviewboard/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/__init__.py

reviewboard/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```

Change Summary:

Always run setup, even when is_running_test is True.