• 
      

    Fix bad state assumptions in the DynamicURLResolver tests.

    Review Request #8708 — Created Feb. 3, 2017 and submitted

    Information

    Djblets
    release-0.10.x
    e1b28ea...

    Reviewers

    The DynamicURLResolver tests had an order dependency issue. They assumed
    that no prior test would populate the URL resolution caches. This was a
    terrible assumption, and the recent extension work broke this.
    
    We now make sure to clear the URL caches before and after the test,
    fixing this particular problem. Some of the inner workings of the test
    have also been cleaned up, making the test more self-contained.

    All unit tests pass on Django 1.6 and 1.8 through 1.10.

    Description From Last Updated

    'settings' imported but unused

    reviewbotreviewbot

    'set_urlconf' imported but unused

    reviewbotreviewbot
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          djblets/urls/tests.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          djblets/urls/tests.py
      
      
    2. djblets/urls/tests.py (Diff revision 1)
       
       
      Show all issues
       'settings' imported but unused
      
    3. djblets/urls/tests.py (Diff revision 1)
       
       
      Show all issues
       'set_urlconf' imported but unused
      
    4. 
        
    david
    1. Once Review Bot is happy, I am.

    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.10.x (b22fecb)