• 
      

    Instantiate a Template instance when rendering custom webhook content.

    Review Request #8702 — Created Jan. 31, 2017 and submitted

    Information

    Review Board
    release-3.0.x
    184fd0c...

    Reviewers

    We use Django's template language for allowing people to render custom webhook
    content, but we deliberately limit the tags and filters that people are allowed
    to use. Previously we just instantiated the Parser and told the resulting
    nodelist to render, but in Django 1.8 there's some code that relies on having a
    Template object for state. This change creates a Template and then replaces
    its nodelist with our parsed version.

    Ran unit tests with Django 1.6 and 1.8.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/notifications/webhooks.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/notifications/webhooks.py
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (a216910)