Summary

Update for some moved items in django.template

Review Request #8693 — Created Jan. 31, 2017 and submitted Jan. 31, 2017, 10:09 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

eb46854...

Reviewers

Groups

reviewboard

People

Description

Django moved the locations of some classes and methods within the
django.template module. This change updates our code for the new location.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
This works on 1.6 and 1.8+?	brennie	Jan. 31, 2017, 3:04 p.m.
Context is supposed to be from django.template for the widest compatibility.	chipx86	Jan. 31, 2017, 10:43 p.m.
This should come from django.template.	chipx86	Jan. 31, 2017, 10:43 p.m.
add_to_builtins doesn't exist in 1.9+. We'll need to revisit this whole file.	chipx86	Jan. 31, 2017, 10:41 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/site/templatetags/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/webhooks.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/site/templatetags/__init__.py

The issue has been resolved. Show all issues
```
This works on 1.6 and 1.8+?
```
1. david Jan. 31, 2017, 3:04 p.m.
  Yep.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (99bf571)

reviewboard/notifications/webhooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Context is supposed to be from django.template for the widest compatibility.
```
reviewboard/reviews/builtin_fields.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should come from django.template.
```
reviewboard/site/templatetags/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
add_to_builtins doesn't exist in 1.9+. We'll need to revisit this whole file.
```