Fix up a couple unit tests that relied on database ordering.
Review Request #8691 — Created Jan. 31, 2017 and submitted
There were a couple unit tests that checked the order of comments returned in a
query after saving. This test was somewhat fragile to the way that the database
backend would decide to return them, and had started failing for me. Since we
care specifically about the order of the timestamps, I've fixed up the tests to
provideorder_by('timestamp')and the tests pass as expected.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
'FileAttachment' imported but unused |
 reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
Can you put the ending ) on its own line? That's how we have it for the other multi-line queries. |
 chipx86
|
|
|
Same here. |
chipx86
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+9 -9) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/tests/test_views.py Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/tests/test_views.py
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 2) Can you put the ending
)on its own line? That's how we have it for the other multi-line queries. -
Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/tests/test_views.py Tool: Pyflakes Processed Files: reviewboard/reviews/tests/test_views.py