Fix using ?only-fields= on the user resource with private profiles.

Review Request #8683 — Created Jan. 30, 2017 and submitted — Latest diff uploaded

Information

Review Board
release-2.5.x
b9bee4c...

Reviewers

When serializing a user in the API who has private profiles enabled,
we'd try to remove some data from the resulting payload. However, if the
caller used ?only-fields= and didn't specify those fields, the
serialization process would crash. We now catch any errors here and
ignore them.

Unit tests were added to ensure this doesn't regress.

The new unit test failed before the fix, and passed after.