Summary

Fix using ?only-fields= on the user resource with private profiles.

Review Request #8683 — Created Jan. 30, 2017 and submitted Feb. 8, 2017, 4:38 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

b9bee4c...

Reviewers

Groups

reviewboard

People

Description

When serializing a user in the API who has private profiles enabled,
we'd try to remove some data from the resulting payload. However, if the
caller used ?only-fields= and didn't specify those fields, the
serialization process would crash. We now catch any errors here and
ignore them.

Unit tests were added to ensure this doesn't regress.

Testing Done

The new unit test failed before the fix, and passed after.

Issues

Description	From	Last Updated
Typo: thisa	david	Feb. 6, 2017, 2:36 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

```
Thanks for fixing this!
```
reviewboard/webapi/resources/user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Typo: thisa
```

Ship it!

```
LGTM, pending David's issue.
```

Change Summary:

Fixed a typo.

Commit:

f2bfc8525e777faa8b1dec06d90e35a5a2f605fd

b9bee4c68795922b8202b2dacedc2dead074f5d1

Diff:

Revision 2 (+26 -1)

Show changes

	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (8594669)