• 
      

    Catch VersionControlException when doing diffs.

    Review Request #8671 — Created Jan. 27, 2017 and submitted

    Information

    rb-tfs
    master
    ecbd184...

    Reviewers

    A number of things in the TFS SDK can throw VersionControlException, which is
    apparently an unchecked exception, and therefore wasn't included in any of the
    docs for the affected methods. This was showing up in a customer's environment
    where a timeout when fetching data from the server wasn't causing "rbt post" to
    fail, but the resulting broken diff would fail to apply.

    This change adds the relevant type to the catch, and fixes up the
    alphabetization on the imports. This also fixes a place where I forgot to
    update the version number of the TFS SDK.

    Built the adapter and pushed to AWS. Smoke tested "rbt diff" and "rbt post".

    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          ivy.xml
          org/reviewboard/tfs/TFSDiffer.java
      
      
      
      Tool: Pyflakes
      Ignored Files:
          ivy.xml
          org/reviewboard/tfs/TFSDiffer.java
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (2b4c1f9)