Fix a Unicode issue when normalizing diffs for Bitbucket.

Review Request #8663 — Created Jan. 24, 2017 and submitted

Information

Review Board
release-2.5.x
d8d9741...

Reviewers

We attempt to append a trailing newline to diffs on Bitbucket, if one
doesn't exist. However, we were doing that by comparing against Unicode
strings, which results in UnicodeDecodeErrors. We now properly use byte
strings instead.

The new unit test failed prior to this fix with the reported error. It
succeeded after the fix.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/tests/test_bitbucket.py
        reviewboard/hostingsvcs/bitbucket.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/tests/test_bitbucket.py
        reviewboard/hostingsvcs/bitbucket.py
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (7aaa519)