• 
      

    Add a Sphinx extension for collecting additional source files.

    Review Request #8654 — Created Jan. 21, 2017 and submitted

    Information

    beanbag-docutils
    master
    bda591d...

    Reviewers

    Sphinx only copies the source files and attachments that are referenced
    into the build directory, meaning that if you have additional files you
    want to include, you have to copy them manually in the Makefile.
    
    This change introduces a new extension, collect_files, that takes a list
    of filenames/patterns and collects those from within the source
    directory to the right place in the build directory.

    Tested this with some changes in one of our doc bundles. Successfully
    collected some files at different levels in the tree.

    Description From Last Updated

    I don't see a return statement in this function.

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          beanbag_docutils/sphinx/ext/collect_files.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          beanbag_docutils/sphinx/ext/collect_files.py
      
      
    2. 
        
    david
    1. 
        
    2. beanbag_docutils/sphinx/ext/collect_files.py (Diff revision 1)
       
       
       
       
      Show all issues

      I don't see a return statement in this function.

      1. Oops. Copied that doc from a function for a different signal.

    3. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          beanbag_docutils/sphinx/ext/collect_files.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          beanbag_docutils/sphinx/ext/collect_files.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (d8ce8ac)