• 
      

    Clean up the markup, style, and editing for checklists.

    Review Request #8651 — Created Jan. 21, 2017 and submitted

    Information

    rb-extension-pack
    master
    3a2f47c...

    Reviewers

    The markup and CSS for the checklist was pretty ugly, and the way that items
    were edited was awkward (cramming an <input> element into the row and
    requiring users to know to hit "enter" or "escape"). This change cleans things
    up in the implementation, polishes up the look a bit, and changes editing to
    use contenteditable on the text element.

    Created, edited, checked/unchecked, and removed items.


    Description From Last Updated

    Selectors in alphabetical order.

    brenniebrennie

    We don't use // comments anywhere really.

    brenniebrennie
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
          rbchecklist/rbchecklist/static/css/style.less
      
      
      
      Tool: Pyflakes
      Ignored Files:
          rbchecklist/rbchecklist/static/js/views/checklistView.es6.js
          rbchecklist/rbchecklist/static/css/style.less
      
      
    2. 
        
    brennie
    1. 
        
    2. Show all issues

      Selectors in alphabetical order.

      1. This is changing quite a bit in a future change, so I'm going to skip this for now.

    3. Show all issues

      We don't use // comments anywhere really.

      1. Yes we do. We use them for single-line comments.

    4. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (0cc7829)