Added cap to filename header
Review Request #8646 — Created Jan. 20, 2017 and submitted — Latest diff uploaded
Clients occasionally dump a ton of data in the filename e-mail headers, which many SMTP servers reject.
To combat this, I have added a limit to the number of characters (8192 characters) that these filename headers may contain. Once this limit is reached, additional filename headers are not added.
Sent e-mail through gmail servers; cap worked correctly.
Unit test was added that checks for correct logger warning, as well as testing the correct overflow behavior.
Diff Revision 12
This is not the most recent revision of the diff. The latest diff is revision 21. See what's changed.
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
| reviewboard/notifications/email.py |
|---|
| reviewboard/notifications/tests.py |
|---|