Summary

Support managing OAuth2 applications in the db

Review Request #8630 — Created Jan. 17, 2017 and submitted April 4, 2017, 12:24 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

eb6e91b...

Reviewers

Groups

reviewboard

People

Description

ReviewBoard now depends on django-oauth-toolkit to provide support as
an OAuth2 identity provider for OAuth2 client applications. This first
patch allows applications to be managed in the database by
administrators. We use our own custom application model to allow
applications to be limited to LocalSites, as well as for attaching
extra data fields to them.

This patch also provides help text for the application form fields, most
of which were missing them.

Testing Done

I was able to create an application in the database successfully.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Jan. 17, 2017, 3:51 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 17, 2017, 3:51 p.m.
'RelatedUserWidget' imported but unused	reviewbot	Jan. 18, 2017, 1:28 p.m.
'django_reset' imported but unused	reviewbot	Jan. 18, 2017, 1:29 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 18, 2017, 1:29 p.m.
Do we need to limit the version here to ensure compatibility with Django 1.6.x?	david	Jan. 24, 2017, 1:39 p.m.
Class docstring?	david	Jan. 24, 2017, 1:40 p.m.
This is kind of hard to read. Can we do all the help text on the next line and indented …	david	Jan. 24, 2017, 1:41 p.m.
d before o.	david	Jan. 24, 2017, 1:42 p.m.
We should have _('Local Site') as the first argument to this to provide a localizable name in the admin.	david	Jan. 24, 2017, 1:43 p.m.
Same here with localizable name.	david	Jan. 24, 2017, 1:43 p.m.
'django_reset' imported but unused	reviewbot	Jan. 18, 2017, 1:28 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 18, 2017, 1:28 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 24, 2017, 3:09 p.m.
'override_feature_check' imported but unused	reviewbot	Jan. 25, 2017, 1:46 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 25, 2017, 2:24 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 25, 2017, 2:25 p.m.
Col: 43 W291 trailing whitespace	reviewbot	Jan. 25, 2017, 2:25 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 25, 2017, 2:28 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 25, 2017, 2:29 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Jan. 25, 2017, 2:29 p.m.
'django_reset' imported but unused	reviewbot	Jan. 25, 2017, 2:29 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 25, 2017, 2:29 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 25, 2017, 2:29 p.m.
'django_reset' imported but unused	reviewbot	Jan. 25, 2017, 2:29 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 25, 2017, 2:29 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Jan. 26, 2017, 12:28 p.m.
Formatting has to happen outside of _()	david	Feb. 22, 2017, 2:11 p.m.
As of Django 1.7, this needs to define either fields or excludes. To match the behavior you have here, use …	david	Feb. 22, 2017, 2:22 p.m.
Please add a Meta here that defines app_label, db_table, and has localized versions of verbose_name and verbose_name_plural	david	Feb. 22, 2017, 2:22 p.m.
'django_reset' imported but unused	reviewbot	Jan. 26, 2017, 12:28 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Jan. 26, 2017, 12:28 p.m.
Should be indented 2 spaces.	david	Feb. 22, 2017, 2:23 p.m.
This must also return self.cleaned_data.	chipx86	March 2, 2017, 1:45 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	Feb. 22, 2017, 2:50 p.m.
"but it" -> "but"	chipx86	March 2, 2017, 1:45 p.m.
"the are" -> "they are"	chipx86	March 2, 2017, 1:45 p.m.
"users' passwords"	chipx86	March 2, 2017, 1:46 p.m.
Rather than space-separated, can we include a textarea and make it line-separated?	chipx86	March 6, 2017, 6:14 p.m.
Probably want to say "unchecked" instead of "false", I would guess.	chipx86	March 6, 2017, 6:14 p.m.
"is a" -> "is"	chipx86	March 6, 2017, 6:14 p.m.
'django_reset' imported but unused	reviewbot	Feb. 22, 2017, 2:50 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 22, 2017, 2:51 p.m.
Blank line between these.	chipx86	March 6, 2017, 6:16 p.m.
Should include the name of the block. Makes it easier to see in larger templates.	chipx86	March 6, 2017, 6:16 p.m.
Missing "Returns."	chipx86	March 14, 2017, 3:01 p.m.
Col: 80 E501 line too long (88 > 79 characters)	reviewbot	March 6, 2017, 10:15 p.m.
You can wrap before the <. It's valid.	chipx86	March 14, 2017, 3:01 p.m.
Minor thing, but technically you should get cleaned_data from this, modify that, and return it directly, instead of using self.cleaned_data. …	chipx86	March 14, 2017, 3:01 p.m.
'django_reset' imported but unused	reviewbot	March 6, 2017, 10:15 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 6, 2017, 10:15 p.m.
File doc comment?	david	March 21, 2017, 5:58 p.m.
This should use ugettext instead of ugettext_lazy.	david	March 21, 2017, 5:58 p.m.
Localized field name?	david	March 21, 2017, 5:58 p.m.
Having random blank lines in the middle of this list when there aren't comments is weird. Can we clean that …	david	March 21, 2017, 6:05 p.m.
'django_reset' imported but unused	reviewbot	March 14, 2017, 3:21 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 14, 2017, 3:22 p.m.
Blank line after this.	david	April 4, 2017, 12:23 p.m.
'django_reset' imported but unused	reviewbot	March 24, 2017, 7:13 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 24, 2017, 7:13 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 2 (+125)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py

reviewboard/oauth/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 'RelatedUserWidget' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 3 (+124)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/settings.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/oauth/__init__.py

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/dependencies.py (Diff revision 3)

The issue has been resolved. Show all issues

Do we need to limit the version here to ensure compatibility with Django 1.6.x?

brennie Jan. 24, 2017, 1:44 p.m.

Indeed, we can't even use this package -- we have to use an older one.

reviewboard/oauth/admin.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Class docstring?
```

reviewboard/oauth/forms.py (Diff revision 3)

The issue has been resolved. Show all issues

This is kind of hard to read. Can we do all the help text on the next line and indented 4 spaces?

reviewboard/oauth/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
d before o.
```
1. brennie Jan. 24, 2017, 1:44 p.m.
  A B O D E F J ...

reviewboard/oauth/models.py (Diff revision 3)

The issue has been resolved. Show all issues

We should have _('Local Site') as the first argument to this to provide a localizable name in the admin.

reviewboard/oauth/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Same here with localizable name.
```

Change Summary:


Address David's issues.
Add a change_list template that warns when oauth applications are not enabled (and therefore their owning user cannot modify them).

Diff:

Revision 4 (+174 -29)

Show changes

	reviewboard/dependencies.py
	reviewboard/features/checkers.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/oauth/tests.py
	reviewboard/static/rb/css/pages/admin.less
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py
    reviewboard/oauth/tests.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py
    reviewboard/oauth/tests.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/oauth/tests.py (Diff revision 4)
The issue has been resolved. Show all issues
```
 'override_feature_check' imported but unused
```

Diff:

Revision 5 (+163 -29)

Show changes

	reviewboard/dependencies.py
	reviewboard/features/checkers.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/templates/admin/oauth/application/change_list.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less



Tool: Pyflakes
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Diff:

Revision 6 (+163 -30)

Show changes

	reviewboard/dependencies.py
	reviewboard/features/checkers.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/templates/admin/oauth/application/change_list.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less



Tool: Pyflakes
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/oauth/models.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 43
 W291 trailing whitespace
```

Diff:

Revision 7 (+162 -29)

Show changes

	reviewboard/dependencies.py
	reviewboard/features/checkers.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/templates/admin/oauth/application/change_list.html

Tool: Pyflakes
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 7)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```

Change Summary:

Post the correct change .....

Diff:

Revision 8 (+267 -9)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/features/checkers.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/oauth/models.py (Diff revision 8)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```
reviewboard/settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Diff:

Revision 9 (+266 -9)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/features/checkers.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	2 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less



Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/oauth/forms.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/features/checkers.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 9)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Change Summary:

detangle changes.

Diff:

Revision 10 (+258)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/static/rb/css/pages/admin.less
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/oauth/__init__.py
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 10)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Because we're introducing a new app, we should simultaneously introduce an AppConfig for django 1.7+. The apps in djblets 0.10 have examples.

reviewboard/oauth/forms.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Formatting has to happen outside of _()
```

reviewboard/oauth/forms.py (Diff revision 10)

The issue has been resolved. Show all issues

As of Django 1.7, this needs to define either fields or excludes. To match the behavior you have here, use fields = '__all__'

reviewboard/oauth/models.py (Diff revision 10)

The issue has been resolved. Show all issues

Please add a Meta here that defines app_label, db_table, and has localized versions of verbose_name and verbose_name_plural

reviewboard/static/rb/css/pages/admin.less (Diff revision 10)
The issue has been resolved. Show all issues
```
Should be indented 2 spaces.
```

Change Summary:

Add compat for django 1.7+

Diff:

Revision 11 (+268)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py
	reviewboard/static/rb/css/pages/admin.less
	1 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less



Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py

Ignored Files:
    reviewboard/templates/admin/oauth/application/change_list.html
    reviewboard/static/rb/css/pages/admin.less

reviewboard/oauth/forms.py (Diff revision 11)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

This looks great, Barret! Thanks, and sorry it took so long to get around to it.

My comments just concern typos and very trivial things.

reviewboard/oauth/forms.py (Diff revision 11)
The issue has been resolved. Show all issues
```
This must also return self.cleaned_data.
```
reviewboard/oauth/forms.py (Diff revision 11)
The issue has been resolved. Show all issues
```
"but it" -> "but"
```
reviewboard/oauth/forms.py (Diff revision 11)
The issue has been resolved. Show all issues
```
"the are" -> "they are"
```
reviewboard/oauth/forms.py (Diff revision 11)
The issue has been resolved. Show all issues
```
"users' passwords"
```

reviewboard/oauth/forms.py (Diff revision 11)

The issue has been resolved. Show all issues

Rather than space-separated, can we include a textarea and make it line-separated?

reviewboard/oauth/forms.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Probably want to say "unchecked" instead of "false", I would guess.
```
reviewboard/oauth/models.py (Diff revision 11)
The issue has been resolved. Show all issues
```
"is a" -> "is"
```
reviewboard/templates/admin/oauth/application/change_list.html (Diff revision 11)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/templates/admin/oauth/application/change_list.html (Diff revision 11)
The issue has been resolved. Show all issues
```
Should include the name of the block. Makes it easier to see in larger templates.
```

Diff:

Revision 12 (+262)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/apps.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py



Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py

reviewboard/oauth/forms.py (Diff revision 12)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (88 > 79 characters)
```
reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

```
Trivial stuff. I'm happy after this.
```
reviewboard/oauth/forms.py (Diff revision 12)
The issue has been resolved. Show all issues
```
Missing "Returns."
```
reviewboard/oauth/forms.py (Diff revision 12)
The issue has been resolved. Show all issues
```
You can wrap before the <. It's valid.
```

reviewboard/oauth/forms.py (Diff revision 12)

The issue has been resolved. Show all issues

Minor thing, but technically you should get cleaned_data from this, modify that, and return it directly, instead of using self.cleaned_data. In practice, it doesn't matter really, since it's set by the base Form.clean(), but worth doing.

Diff:

Revision 13 (+267)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/apps.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py

reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/oauth/apps.py (Diff revision 13)
The issue has been resolved. Show all issues
```
File doc comment?
```
reviewboard/oauth/forms.py (Diff revision 13)
The issue has been resolved. Show all issues
```
This should use ugettext instead of ugettext_lazy.
```
reviewboard/oauth/models.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Localized field name?
```

reviewboard/settings.py (Diff revision 13)

The issue has been resolved. Show all issues

Having random blank lines in the middle of this list when there aren't comments is weird. Can we clean that up?

Commit:

74f42f99521fe263f71800c41789d7d60d93ad1b

eb6e91bc026b7eae7ddb03ad16090155511b7bee

Diff:

Revision 14 (+272 -1)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/oauth/__init__.py
	reviewboard/oauth/admin.py
	reviewboard/oauth/apps.py
	reviewboard/oauth/features.py
	reviewboard/oauth/forms.py
	reviewboard/oauth/models.py

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/dependencies.py
    reviewboard/oauth/__init__.py
    reviewboard/oauth/models.py
    reviewboard/oauth/features.py
    reviewboard/oauth/forms.py
    reviewboard/oauth/admin.py
    reviewboard/oauth/apps.py

reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

reviewboard/oauth/apps.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Blank line after this.
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (9826566)