Summary

Fix a couple bugs caused by passing in unicode headers to urlopen.

Review Request #8619 — Created Jan. 16, 2017 and submitted Jan. 16, 2017, 11:57 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

4069, 4472

Depends On

Commit

eabc9c4...

Reviewers

Groups

reviewboard

People

Description

urlopen is happy to accept a unicode object for headers, but it then tries to
use the ascii codec to encode them. If the text includes something that can't
be encoded, it would fail. This change fixes up a couple places where this was
causing problems for people.

Testing Done

Ran unit tests.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/hostingsvcs/service.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/hostingsvcs/service.py

Ship it!

```
Can you backport this to release-2.0.x?
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (6cd4753)