Fix 500 errors from upstream files not existing

Review Request #8591 - Created Jan. 4, 2017 and submitted

Barret Rennie
Review Board
release-2.5.x
88b9deb...
reviewboard

Previously, trying to download a original or modified file based on an
upstream file that does not exist would result in a 500 error. Now we
check for that case and, if the file does not exist, we return a 404
error instead. Unit tests have been added to ensure this behaviour does
not regress.

Testing done:
Ran unit tests.

Ran unit tests.

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Review Bot
Christian Hammond
Barret Rennie
Review Bot
David Trowbridge
Barret Rennie
Review Bot
Christian Hammond
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (1f34ec8)
Loading...